Ticket #2 (closed enhancement: fixed)

Opened 21 months ago

Last modified 11 months ago

Virtual Host Aliases

Reported by: edsiper Owned by: edsiper
Priority: major Milestone: 0.12.0
Component: Virtual Host Version:
Keywords: Cc:

Description

Currently Monkey Virtual Host configuration just accepts one host name, it
must accept aliases in order to avoid to have N virtual hosts defined, eg:

Current:

ServerName? www.somesite.com

Expected:

ServerName? somesite.com www.somesite.com calendar.somesite.com

Attachments

Add-virtual-host-aliases-support.patch Download (2.7 KB) - added by charlie_brown 19 months ago.
Add support for aliases

Change History

comment:1 Changed 19 months ago by edsiper

  • Milestone changed from 0.11.0 to 0.12.0

Changed 19 months ago by charlie_brown

Add support for aliases

comment:2 Changed 19 months ago by charlie_brown

My proposal is to add an "Aliases" optional keyword. For example:

ServerName www.somesite.com
Aliases calendar.somesite.com othersite whatever

(patch attached)

comment:3 Changed 19 months ago by edsiper

  • Status changed from new to accepted

Thanks for the patch and proposal.

After review and re-think how we should handle this feature, the best one is to handle everything in the single variable ServerName?, on this way we avoid to add an extra configuration key and at code level the parsing is more simple.

This implemented feature must avoid to copy strings when a request is parsed.

Also this feature must take care of the host information when is sent to different parts of the core, not just to match the right hostname.

comment:4 Changed 15 months ago by edsiper

  • Status changed from accepted to closed
  • Resolution set to fixed

Fixed in :

 http://git.monkey-project.com/?p=monkey;a=commitdiff;h=7163f64ed4b757d5bdc43e87c4815ea90e5f0d0c

Now the directive Servername, allow multiple aliases in the same line.

comment:5 Changed 11 months ago by amog2011

Also this feature must take care of the host information when is sent to different parts of the core, not just to match the right hostname.

air jordan
Last edited 11 months ago by amog2011 (previous) (diff)

comment:6 Changed 11 months ago by edsiper

Are you reporting a bug or an unexpected behavior ?, please provide more details.

Note: See TracTickets for help on using tickets.